Skip to content

ports/rp2: Fix flash size check in CMakeLists.txt. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ports/rp2: Fix flash size check in CMakeLists.txt. #1

wants to merge 1 commit into from

Conversation

sfe-SparkFro
Copy link
Collaborator

Summary

See micropython#17344 (comment)

Testing

Tested building a handful of boards with a debug print added to each if() branch to verify the correct branch is executed.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2025

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@sfe-SparkFro
Copy link
Collaborator Author

No wonder this never got addressed, PR was made against the wrong repo 🤦

@sfe-SparkFro sfe-SparkFro deleted the fix_rp2_flash_size_check branch August 1, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfe-SparkFro